Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CURA-11956] The easy way to fix a slow response is to up the timeout... #19503

Merged
merged 2 commits into from
Aug 14, 2024
Merged

[CURA-11956] The easy way to fix a slow response is to up the timeout... #19503

merged 2 commits into from
Aug 14, 2024

Conversation

rburema
Copy link
Member

@rburema rburema commented Aug 7, 2024

This might on one hand have (other) consequences, and given the slowness we encounter not even be enough in some cases (may be related to the size of the messages?) May need to be fixed on server side.

@rburema
The easy way to fix a slow response is to up the timeout.
77e0d70 
This might on one hand have (other) consequences, and given the slowness we encounter not even be enough in some cases (may be related to the size of the messages?) May need to be fixed on server side.

attempt to adress CURA-11956
@wawanbreton
Copy link
Contributor

Should this PR be undrafted ?

Could we, instead of using a timeout, monitor the sent bytes, and cancel the request if they don't grow up ? This way we could set a longer timeout, which would be the ultimate security only.

@rburema
Copy link
Member Author

rburema commented Aug 13, 2024

Should this PR be undrafted ?

It felt like a bit of a hack, so I made it a draft.

Could we, instead of using a timeout, monitor the sent bytes, and cancel the request if they don't grow up ? This way we could set a longer timeout, which would be the ultimate security only.

Maybe? I haven't tried it, so I'm not sure if anything actually comes in before the deadline.

@wawanbreton
Copy link
Contributor

Maybe? I haven't tried it, so I'm not sure if anything actually comes in before the deadline.

This probably uses a QNetworkReply, which has an uploadProgress signal. So technically it should be doable, but it is a much larger change 😃

@rburema rburema marked this pull request as ready for review August 13, 2024 09:51
@HellAholic HellAholic merged commit 4cd8056 into main Aug 14, 2024
9 checks passed
@HellAholic HellAholic deleted the CURA-11956_slow_upload_big_timeout branch August 14, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawanbreton wawanbreton wawanbreton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rburema @wawanbreton @HellAholic